Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to index.ros.org. #244

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

clalancette
Copy link
Contributor

No description provided.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette requested a review from tfoote as a code owner April 16, 2024 00:13
Copy link
Contributor

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to resolve referencing docs.ros.org vs index.ros.org overall and have a better flow between them. The shorter url and simpler pattern and multi version headers were one of the things that made the wiki very powerful.

This embedding the rolling into the url is suboptimal. Maybe what we should be doing like the wiki is creating an autogenerated header with the index content on docs.ros.org that's embedded instead of on a standalone page, that can help with the cross referencing and navigation more easily.

@clalancette
Copy link
Contributor Author

This embedding the rolling into the url is suboptimal.

Yeah, totally agreed.

Maybe what we should be doing like the wiki is creating an autogenerated header with the index content on docs.ros.org that's embedded instead of on a standalone page, that can help with the cross referencing and navigation more easily.

Yeah, that is a good idea. I still think we should take this for now, as at least we'll be pointing to a page that exists (even though it will be the incorrect version for e.g. Jazzy).

@tfoote tfoote merged commit 9da4a19 into rolling Apr 16, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the clalancette/remove-index-ros-org branch April 16, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants